Fixed issue preventing README.md client example from compiling.#346
Merged
halter73 merged 1 commit intomodelcontextprotocol:mainfrom Apr 23, 2025
Merged
Fixed issue preventing README.md client example from compiling.#346halter73 merged 1 commit intomodelcontextprotocol:mainfrom
halter73 merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a compilation issue in the README.md client example by updating the CancellationToken usage to a named parameter, and also corrects a spelling error in the acknowledgements.
- Updated the CancellationToken parameter from positional to named.
- Corrected the spelling error from "Pederson" to "Pedersen" in the acknowledgements.
Comments suppressed due to low confidence (1)
README.md:223
- The spelling correction from 'Pederson' to 'Pedersen' appears correct. Confirm that this change aligns with the intended attribution.
The starting point for this library was a project called [mcpdotnet](https://github.com/PederHP/mcpdotnet), initiated by [Peder Holdgaard Pedersen](https://github.com/PederHP).
halter73
approved these changes
Apr 23, 2025
Contributor
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
I also fixed a spelling error in my name ;).
Sorry!
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes mean that we need to use a named CancellationToken parameter as it is no longer the third parameter. I also fixed a spelling error in my name ;).